RFR: 8346184: C2: assert(has_node(i)) failed during split thru phi
Roland Westrelin
roland at openjdk.org
Wed Jan 8 13:20:40 UTC 2025
On Thu, 19 Dec 2024 14:12:34 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
> Looks reasonable. Does the new node come from here?
>
> https://github.com/openjdk/jdk/blob/f6e7713bb653811423eeb2515c2f69b437750326/src/hotspot/share/opto/memnode.cpp#L1211-L1215
Yes, it does.
> Should we generally add some verification code that `Identity()` does not create new nodes? Hard to do it at all places but it could, for example, be done in the `transform()` methods of GVN and IGVN when calling `Identity()`. But of course, should probably be done in a separate RFE.
That sounds like a good idea. I filed: https://bugs.openjdk.org/browse/JDK-8347266
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22818#issuecomment-2577652447
More information about the hotspot-compiler-dev
mailing list