RFR: 8346184: C2: assert(has_node(i)) failed during split thru phi

[Roland Westrelin]

On Thu, 19 Dec 2024 15:14:11 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> The new test is failing with the following flags on linux-x64-debug:
> 
> ```
> -XX:-TieredCompilation -XX:+StressReflectiveCode -XX:-ReduceInitialCardMarks -XX:-ReduceBulkZeroing -XX:-ReduceFieldZeroing
> ```

The problem here is that the calls to `can_see_stored_value()` from `Identity` and `Value` are not guarded by the same conditions. The one from `Value` only happens if `ReduceFieldZeroing` is true but `Identity` doesn't check that flag. I fixed this by making  `Identity` and `Value` call `can_see_stored_value()` unconditionally. (see new commits)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22818#issuecomment-2577707132