RFR: 8330851: C2: More efficient TypeFunc creation [v7]

[Vladimir Ivanov]

On Tue, 24 Dec 2024 05:39:50 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Lazy computation of TypeFunc.
>> 
>> Testing: Tier1 on Fastdebug & Release VMs (`s390x architecture`)
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   [wip] renamed caches, changed type factories, refactored code

src/hotspot/share/opto/callnode.hpp line 1193:

> 1191: //
> 1192: class LockNode : public AbstractLockNode {
> 1193:   static const TypeFunc *_lock_type_Type;

Comment on code style: `TypeFunc* _lock_type_Type`.

src/hotspot/share/opto/callnode.hpp line 1196:

> 1194: public:
> 1195: 
> 1196:   static inline const TypeFunc *lock_type() {

Suggestion: `static inline const TypeFunc* lock_type() {`

src/hotspot/share/opto/type.cpp line 716:

> 714:   mreg2type[Op_VecZ] = TypeVect::VECTZ;
> 715: 
> 716:   LockNode::lock_type_init();

Would be nice to have consistent naming here (e.g., `initialize_types` or even `initialize_c2_types`).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21782#discussion_r1906000714
PR Review Comment: https://git.openjdk.org/jdk/pull/21782#discussion_r1906001829
PR Review Comment: https://git.openjdk.org/jdk/pull/21782#discussion_r1906003717