RFR: 8330851: C2: More efficient TypeFunc creation [v7]

[Amit Kumar]

On Tue, 7 Jan 2025 20:28:20 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   [wip] renamed caches, changed type factories, refactored code
>
> src/hotspot/share/opto/callnode.hpp line 1196:
> 
>> 1194: public:
>> 1195: 
>> 1196:   static inline const TypeFunc *lock_type() {
> 
> Suggestion: `static inline const TypeFunc* lock_type() {`

Sorry, that was my editor's default behaviour. Updated.

> src/hotspot/share/opto/type.cpp line 716:
> 
>> 714:   mreg2type[Op_VecZ] = TypeVect::VECTZ;
>> 715: 
>> 716:   LockNode::lock_type_init();
> 
> Would be nice to have consistent naming here (e.g., `initialize_types` or even `initialize_c2_types`).

I have updated name, can you take another look if they look fine now ? Thanks

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21782#discussion_r1906533137
PR Review Comment: https://git.openjdk.org/jdk/pull/21782#discussion_r1906532013