RFR: 8345766: C2 should emit macro nodes for ModF/ModD instead of calls during parsing [v3]

Theo Weidmann tweidmann at openjdk.org
Thu Jan 9 11:12:44 UTC 2025


On Tue, 7 Jan 2025 17:00:44 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Theo Weidmann has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Merge branch '8345766-floating-mod-macro' of https://github.com/theoweidmannoracle/jdk into 8345766-floating-mod-macro
>>  - Use basic type instead
>
> src/hotspot/share/opto/parse2.cpp line 1103:
> 
>> 1101: 
>> 1102:   Node* prev_mem = set_predefined_input_for_runtime_call(mod);
>> 1103:   mod = _gvn.transform(mod)->as_Call();
> 
> Is `as_Call()` used to check with assert?

Yes, as_Call does check with assert

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22786#discussion_r1908577319


More information about the hotspot-compiler-dev mailing list