RFR: 8345766: C2 should emit macro nodes for ModF/ModD instead of calls during parsing [v6]
Theo Weidmann
tweidmann at openjdk.org
Thu Jan 9 14:39:43 UTC 2025
On Tue, 7 Jan 2025 18:26:40 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Theo Weidmann has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Address comments
>> - Actually return top
>> - Update divnode.cpp
>
> Most likely it will affect performance of 32-bit x86 since it was simple nodes and not Call nodes. But the platforma is going away so it should be fine.
>
> You need to treat new Mod nodes as leaf calls without side effects instead of general Call nodes.
@vnkozlov @eme64 Thank you for your reviews. I think I addressed your comments and will run testing again.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22786#issuecomment-2580408648
More information about the hotspot-compiler-dev
mailing list