RFR: 8345766: C2 should emit macro nodes for ModF/ModD instead of calls during parsing [v4]

Theo Weidmann tweidmann at openjdk.org
Thu Jan 9 11:45:59 UTC 2025


On Wed, 8 Jan 2025 08:04:57 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/divnode.cpp line 1401:
>> 
>>> 1399: //=============================================================================
>>> 1400: //------------------------------Idealize---------------------------------------
>>> 1401: Node *UModLNode::Ideal(PhaseGVN *phase, bool can_reshape) {
>> 
>> Suggestion:
>> 
>> Node* UModLNode::Ideal(PhaseGVN* phase, bool can_reshape) {
>> 
>> Ah, maybe you did not mean to touch it, but on GitHub it looks like you did... Maybe you just reordered things.
>
> Makes it a little trickier to review though.

Yes, I think I just re-ordered this without realizing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22786#discussion_r1908634798


More information about the hotspot-compiler-dev mailing list