RFR: 8345766: C2 should emit macro nodes for ModF/ModD instead of calls during parsing [v3]

[Theo Weidmann]

On Wed, 8 Jan 2025 07:59:53 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Theo Weidmann has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Merge branch '8345766-floating-mod-macro' of https://github.com/theoweidmannoracle/jdk into 8345766-floating-mod-macro
>>  - Use basic type instead
>
> src/hotspot/share/opto/divnode.cpp line 61:
> 
>> 59:   init_req(TypeFunc::Parms + 0, a);
>> 60:   init_req(TypeFunc::Parms + 1, b);
>> 61: }
> 
> Is there a reason to put this in the cpp file? I think I usually see constructors for Nodes in the hpp file. Nitpicky sorry 🙈

Yes, I wanted to avoid importing the runtime header (OptoRuntime) into the divnode header.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22786#discussion_r1908579896