RFR: 8341696: C2: Non-fluid StringBuilder pattern bails out in OptoStringConcat [v4]
Theo Weidmann
tweidmann at openjdk.org
Fri Jan 10 09:16:41 UTC 2025
On Wed, 8 Jan 2025 13:06:51 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Theo Weidmann has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix test name
>
> test/hotspot/jtreg/compiler/stringopts/TestFluidAndNonFluid.java line 27:
>
>> 25: * @test
>> 26: * @bug 8341696
>> 27: * @requires vm.compiler2.enabled
>
> Not sure if I asked about this already: do we need this C2 restriction? The IR framework only checks IR rules for C2, but the test could still do value verification for other settings where C2 is not available.
Unintentional. Thanks for spotting it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22537#discussion_r1910049585
More information about the hotspot-compiler-dev
mailing list