RFR: 8341696: C2: Non-fluid StringBuilder pattern bails out in OptoStringConcat [v4]

[Theo Weidmann]

On Wed, 8 Jan 2025 13:23:04 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Theo Weidmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix test name
>
> Looks promising. Though I did not work with string-opts before, so a little hard for me to give a proper review. If you want/need me to review, a few more annotations with github comments would help. Otherwise I'll just leave it at the drive-by comments ;)

@eme64 Thanks for your inputs. I added comments to document and explain the aspects you asked about, renamed symbols and replaced the breaks with more clear return statements. It should be clearer now hopefully.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22537#issuecomment-2582184145