RFR: 8347481: C2: Remove the control input of some nodes
Quan Anh Mai
qamai at openjdk.org
Tue Jan 14 03:40:34 UTC 2025
On Mon, 13 Jan 2025 14:26:15 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:
>> Hi,
>>
>> While working on [JDK-8347365](https://bugs.openjdk.org/browse/JDK-8347365), I noticed that there are some nodes that have their control inputs being set in a seemingly erroneous manner. This patch removes the control inputs for those nodes.
>>
>> Please review this PR, thanks a lot.
>
> Nice cleanup @merykitty. Thanks!
> I was just wondering if there could be more nodes where the control input is wrongly set (possibly enough for a followup issue?)
@dafedafe Thanks, there's `LoadKlassNode` which very rarely takes a control input but the reason given does not convince me. However, it seems to be a less clear cut compared to these nodes so I think a separate RFE is more suitable.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23055#issuecomment-2588851372
More information about the hotspot-compiler-dev
mailing list