RFR: 8347481: C2: Remove the control input of some nodes

Damon Fenacci dfenacci at openjdk.org
Wed Jan 15 14:51:36 UTC 2025


On Sun, 12 Jan 2025 13:43:44 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

> Hi,
> 
> While working on [JDK-8347365](https://bugs.openjdk.org/browse/JDK-8347365), I noticed that there are some nodes that have their control inputs being set in a seemingly erroneous manner. This patch removes the control inputs for those nodes.
> 
> Please review this PR, thanks a lot.

Fair enough. I happened to notice that some other nodes seemed to give the possibility of setting the control input although it might not make sense (e.g. some Div*Node and Mod*Node) and I thought it might be worth having a global look at this at some point.

This fix seems totally OK for me as it is now. Thanks again @merykitty.

-------------

Marked as reviewed by dfenacci (Committer).

PR Review: https://git.openjdk.org/jdk/pull/23055#pullrequestreview-2552986351


More information about the hotspot-compiler-dev mailing list