RFR: 8346107: Generators: testing utility for random value generation [v17]

Christian Hagedorn chagedorn at openjdk.org
Tue Jan 14 17:41:45 UTC 2025


On Tue, 14 Jan 2025 16:33:04 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Min and max are in the set for range >= 1. But I agree that I would make sense to rename it to `powersOfTwo`. @eme64 What do you think?
>
> @theoweidmannoracle sounds fine to me.

> Min and max are in the set for range >= 1. But I agree that I would make sense to rename it to `powersOfTwo`. @eme64 What do you think?

You're right, I read the code wrongly. Maybe you can add a comment that MIN and MAX will also be included with `range >= 1`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22941#discussion_r1915325301


More information about the hotspot-compiler-dev mailing list