RFR: 8346107: Generators: testing utility for random value generation [v17]

Christian Hagedorn chagedorn at openjdk.org
Tue Jan 14 17:41:47 UTC 2025


On Tue, 14 Jan 2025 16:34:05 GMT, Theo Weidmann <tweidmann at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/lib/generators/RandomnessSourceAdapter.java line 32:
>> 
>>> 30:  * See RandomnessSource for more information.
>>> 31:  */
>>> 32: public class RandomnessSourceAdapter implements RandomnessSource {
>> 
>> Is this a class a user must be aware of or could it also be package-private?
>
> I don't think we have to make it public but I also don't think there's any reason to hide it. It's the most straightforward implementation of an adapter between RandomGenerator and RandomnessSource so it's kind of trivial and is very unlikely to change (often).

That's fine 👍

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22941#discussion_r1915325385


More information about the hotspot-compiler-dev mailing list