RFR: 8343685: C2 SuperWord: refactor VPointer with MemPointer [v4]

Emanuel Peter epeter at openjdk.org
Wed Jan 15 07:19:35 UTC 2025


On Wed, 15 Jan 2025 06:51:10 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>>> @vnkozlov thanks for having a look at it! I think I have addressed all your points.
>> 
>> I still have concern about `cmp()` with NaN values. See my comment.
>
>> @vnkozlov thanks for your comments. I just pushed a fix - does that address your concerns? Or would you want more than explanatory comment for `cmp`? If you want something more: what would you consider a good idea? Rename `cmp` to `cmp_where_NaN_before_nonNaN_and_NaN_eq_NaN`?
> 
> New comment looks fine to me. No need to rename method.

@vnkozlov thanks for doing a second pass! I think I addressed everything you brought up.
Let me know if there is anything else I can do :)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21926#issuecomment-2591783169


More information about the hotspot-compiler-dev mailing list