RFR: 8343685: C2 SuperWord: refactor VPointer with MemPointer [v6]

Emanuel Peter epeter at openjdk.org
Thu Jan 16 06:11:46 UTC 2025


On Wed, 15 Jan 2025 12:27:17 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More fixes for vnkozlov
>
> src/hotspot/share/opto/vectorization.hpp line 850:
> 
>> 848:   }
>> 849: 
>> 850:   bool is_adjacent_to_and_before(const VPointer& other) const {
> 
> Maybe you can add an example as a method comment to illustrate this property with two `VPointers` (could also be added at `MemPointer::is_adjacent_to_and_before()` or only there).

Added a comment for `MemPointer::is_adjacent_to_and_before()`, I think that is enough.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21926#discussion_r1917798930


More information about the hotspot-compiler-dev mailing list