RFR: 8343685: C2 SuperWord: refactor VPointer with MemPointer [v6]

[Emanuel Peter]

On Wed, 15 Jan 2025 12:08:26 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More fixes for vnkozlov
>
> src/hotspot/share/opto/vectorization.hpp line 822:
> 
>> 820:   // Greatest common factor among the scales of the invar_summands.
>> 821:   // Out of simplicity, we only factor out positive powers-of-2,
>> 822:   // between 1 and ObjectAlignmentInBytes. If the invar is empty,
> 
> This include 1 and `ObjectAlignmentInBytes`, right? Between X and Y is often ambiguous. Maybe you want to rephrase this to: "between (inclusive) 1 and ObjectAlignmentInBytes"?

Good idea

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21926#discussion_r1917782766