RFR: 8343685: C2 SuperWord: refactor VPointer with MemPointer [v6]

[Emanuel Peter]

On Wed, 15 Jan 2025 12:36:48 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More fixes for vnkozlov
>
> src/hotspot/share/opto/vectorization.hpp line 890:
> 
>> 888: 
>> 889:   // Check that all variables are either the iv, or else invariants.
>> 890:   bool init_is_valid() const {
> 
> You could extract the code to three methods to reduce the size of this method and make it easier to see what's going on:
> 
> bool init_is_valid() const {
>   return is_base_known() && 
>          are_non_iv_summands_pre_loop_invariant() && 
>          scale_and_stride_not_too_large() 
> }

Good idea! Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21926#discussion_r1917837776