RFR: 8343685: C2 SuperWord: refactor VPointer with MemPointer [v6]

[Emanuel Peter]

On Wed, 15 Jan 2025 12:01:31 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More fixes for vnkozlov
>
> src/hotspot/share/opto/vectorization.hpp line 810:
> 
>> 808: 
>> 809:   template<typename Callback>
>> 810:   void for_each_invar_summand(Callback callback) const {
> 
> Even though you talk about `invar_summand` in the descriptive comments, I guess you could be explicit here since it's an API method:
> Suggestion:
> 
>   void for_each_invariant_summand(Callback callback) const {

Let's discuss this below.

> src/hotspot/share/opto/vectorization.hpp line 836:
> 
>> 834:   }
>> 835: 
>> 836:   int count_invar_summands() const {
> 
> Same here, you could be explicit:
> Suggestion:
> 
>   int count_invariant_summands() const {

Let's discuss this below.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21926#discussion_r1917840868
PR Review Comment: https://git.openjdk.org/jdk/pull/21926#discussion_r1917840933