RFR: 8341696: C2: Non-fluid StringBuilder pattern bails out in OptoStringConcat [v5]

Theo Weidmann tweidmann at openjdk.org
Fri Jan 17 08:25:40 UTC 2025


On Thu, 16 Jan 2025 19:12:32 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Theo Weidmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make code more clear
>
> src/hotspot/share/opto/stringopts.hpp line 58:
> 
>> 56:   enum class ProcessAppendResult {
>> 57:     // Indicates that the candidate was indeed an append and process_append_candidate processed it
>> 58:     // accordingly (added it to the StringCocat etc.)
> 
> `StringCocat` -> `StringConcat`

Thanks for spotting this!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22537#discussion_r1919729521


More information about the hotspot-compiler-dev mailing list