RFR: 8341696: C2: Non-fluid StringBuilder pattern bails out in OptoStringConcat [v5]

[Theo Weidmann]

On Thu, 16 Jan 2025 19:22:47 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Theo Weidmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make code more clear
>
> src/hotspot/share/opto/stringopts.cpp line 659:
> 
>> 657:           cnode->in(TypeFunc::Parms + 1)->dump();
>> 658:         }
>> 659: #endif
> 
> This print code could be put into `process_append_candidate()` too as you do for `AbortOptimization`.

This here is printed if the return is `CandidateIsNotAppend` but we don't need to always print this, if the result is `CandidateIsNotAppend`. Further up, we don't care if the result is `CandidateIsNotAppend`, so I don't think it can be moved into `process_append_candidate`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22537#discussion_r1919736392