RFR: 8341696: C2: Non-fluid StringBuilder pattern bails out in OptoStringConcat [v5]

[Vladimir Kozlov]

On Fri, 17 Jan 2025 08:28:52 GMT, Theo Weidmann <tweidmann at openjdk.org> wrote:

>> src/hotspot/share/opto/stringopts.cpp line 659:
>> 
>>> 657:           cnode->in(TypeFunc::Parms + 1)->dump();
>>> 658:         }
>>> 659: #endif
>> 
>> This print code could be put into `process_append_candidate()` too as you do for `AbortOptimization`.
>
> This here is printed if the return is `CandidateIsNotAppend` but we don't need to always print this, if the result is `CandidateIsNotAppend`. Further up, we don't care if the result is `CandidateIsNotAppend`, so I don't think it can be moved into `process_append_candidate`

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22537#discussion_r1920467617