RFR: 8348401: [IR Framework] PrintTimes should not require verbose [v2]
Theo Weidmann
tweidmann at openjdk.org
Mon Jan 27 08:57:05 UTC 2025
On Fri, 24 Jan 2025 17:02:05 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Theo Weidmann has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>>
>> - Merge branch 'master' into 8348401-fix-print-times
>> - Add tag
>> - Update TestVM.java
>> - Update TestVM.java
>
> test/hotspot/jtreg/compiler/lib/ir_framework/test/TestVM.java line 890:
>
>> 888: System.out.println(System.lineSeparator() + System.lineSeparator() + "Test execution times:");
>> 889: for (Map.Entry<Long, String> entry : durations.entrySet()) {
>> 890: TestFrameworkSocket.write(String.format("%-25s%15d ns%n", entry.getValue() + ":", entry.getKey()),
>
> Please, add comment which explains usage of `TestFrameworkSocket` as you did in description.
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23267#discussion_r1930166115
More information about the hotspot-compiler-dev
mailing list