RFR: 8348401: [IR Framework] PrintTimes should not require verbose [v2]

Theo Weidmann tweidmann at openjdk.org
Mon Jan 27 14:13:28 UTC 2025


On Mon, 27 Jan 2025 08:54:16 GMT, Theo Weidmann <tweidmann at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/lib/ir_framework/test/TestVM.java line 890:
>> 
>>> 888:             System.out.println(System.lineSeparator() + System.lineSeparator() + "Test execution times:");
>>> 889:             for (Map.Entry<Long, String> entry : durations.entrySet()) {
>>> 890:                 TestFrameworkSocket.write(String.format("%-25s%15d ns%n", entry.getValue() + ":", entry.getKey()),
>> 
>> Please, add comment which explains usage of `TestFrameworkSocket` as you did in description.
>
> Done

As suggested by Christian below, I placed the comment at TestFrameworkSocket.write

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23267#discussion_r1930589999


More information about the hotspot-compiler-dev mailing list