RFR: 8347405: MergeStores with reverse bytes order value [v10]

[Richard Reingruber]

On Mon, 27 Jan 2025 07:20:49 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> kuaiwei has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix test502aBE
>
> src/hotspot/share/opto/memnode.cpp line 3013:
> 
>> 3011: #else
>> 3012:   return shift_n1 > shift_n2 ? ValueOrder::Platform     // Pattern: [n1 = base >> (shift + memory_size), n2 = base >> shift]
>> 3013:                              : ValueOrder::NotAdjacent; // TODO: Reverse order in BE machine not tested
> 
> Drive-by comment: are you going to address your TODO in this PR? We usually don't just leave TODOs in the code, rather we should file RFE's if we plan to do something in the future. TODOs just get forgotten about.

I missed that one and that the adaptations for BE got lost, sorry.
I'm currently running the tests and will redo the necessary adaptations.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23030#discussion_r1930236297