RFR: 8347405: MergeStores with reverse bytes order value [v10]

[Richard Reingruber]

On Mon, 27 Jan 2025 09:45:01 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> src/hotspot/share/opto/memnode.cpp line 3013:
>> 
>>> 3011: #else
>>> 3012:   return shift_n1 > shift_n2 ? ValueOrder::Platform     // Pattern: [n1 = base >> (shift + memory_size), n2 = base >> shift]
>>> 3013:                              : ValueOrder::NotAdjacent; // TODO: Reverse order in BE machine not tested
>> 
>> Drive-by comment: are you going to address your TODO in this PR? We usually don't just leave TODOs in the code, rather we should file RFE's if we plan to do something in the future. TODOs just get forgotten about.
>
> I missed that one and that the adaptations for BE got lost, sorry.
> I'm currently running the tests and will redo the necessary adaptations.

This commit https://github.com/reinrich/jdk/commit/2e10038b1b6af34a6e4efa98dc905db891e680b7 enables merging of stores in reverse order for BE platforms. TestMergeStores succeeds with it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23030#discussion_r1930552125