RFR: 8319850: PrintInlining should print which methods are late inlines [v27]

[Theo Weidmann]

On Tue, 28 Jan 2025 17:11:35 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Theo Weidmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address comments
>
> I have few comments.

@vnkozlov @dean-long Thanks for taking another look!

> src/hotspot/share/nmt/nmtTreap.hpp line 70:
> 
>> 68:   public:
>> 69:     TreapNode(const K& k, uint64_t p) : _priority(p), _key(k), _left(nullptr), _right(nullptr) {}
>> 70: 
> 
> Why you need these changes in NMT?

First, there is no public find method anyhow. So I needed to add a find method.

Second, the values I place in the NMT (IPInlineSite) are not copyable because they have a GrowableArrayCHeap, which is not copyable.

The solution therefore is to have a find method that finds the existing value in the tree or constructs the value directly in place in the TreapNode (which is why I need the constructor above). This follows a pattern from the C++ standard library.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21899#issuecomment-2620993770
PR Review Comment: https://git.openjdk.org/jdk/pull/21899#discussion_r1933460973