RFR: 8319850: PrintInlining should print which methods are late inlines [v27]
Vladimir Kozlov
kvn at openjdk.org
Wed Jan 29 15:18:06 UTC 2025
On Wed, 29 Jan 2025 08:34:57 GMT, Theo Weidmann <tweidmann at openjdk.org> wrote:
>> src/hotspot/share/nmt/nmtTreap.hpp line 70:
>>
>>> 68: public:
>>> 69: TreapNode(const K& k, uint64_t p) : _priority(p), _key(k), _left(nullptr), _right(nullptr) {}
>>> 70:
>>
>> Why you need these changes in NMT?
>
> First, there is no public find method anyhow. So I needed to add a find method.
>
> Second, the values I place in the NMT (IPInlineSite) are not copyable because they have a GrowableArrayCHeap, which is not copyable.
>
> The solution therefore is to have a find method that finds the existing value in the tree or constructs the value directly in place in the TreapNode (which is why I need the constructor above). This follows a pattern from the C++ standard library.
okay
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21899#discussion_r1934073062
More information about the hotspot-compiler-dev
mailing list