RFR: 8348411: C2: Remove the control input of LoadKlassNode and LoadNKlassNode [v2]
Quan Anh Mai
qamai at openjdk.org
Thu Jan 30 07:56:29 UTC 2025
On Tue, 28 Jan 2025 20:56:30 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove always_see_exact_class
>
> src/hotspot/share/opto/parseHelper.cpp line 168:
>
>> 166: // succeeds.
>> 167: if (MonomorphicArrayCheck && !too_many_traps(Deoptimization::Reason_array_check) && !tak->klass_is_exact()
>> 168: && tak != TypeInstKlassPtr::OBJECT) {
>
> I'd also turn `tak != TypeInstKlassPtr::OBJECT` into `tak->isa_aryklassptr()` to stress the intention.
> (Please, keep the original formatting here.)
Done, I assume you meant the formatting of the comment below, right?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23274#discussion_r1935156156
More information about the hotspot-compiler-dev
mailing list