RFR: 8342393: Promote commutative vector IR node sharing [v20]

[Jatin Bhateja]

On Thu, 30 Jan 2025 13:37:53 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>>> Oh, I see you added it here, rather than at each IR rule. It would be nice to have this test also execute on other machines, for additional coverage.
>>> 
>> These tests are only significant from commoning point of view which is checked through IR rule.
>> 
>> In addition **foundational optimizations like GVN** is target indipendent hence verifying it for a target which supports all the IR nodes covered by test should suffice. Which is why I restricted it to x64.
>
> That would be sad, because we can still profit from all the value verification for other platforms.
> 
> And who knows, we may add similar instructions for other platforms as well, and then the value verification would come in really handy.

I again re-iterate **a foundational optimization like GVN is target indipendent and our intent here is to check commoning**, hence verifying it for a target which supports all the IR nodes covered by test should suffice for now. Kindly proceed with your testing and share the results.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22863#discussion_r1935630855