RFR: 8342393: Promote commutative vector IR node sharing [v20]
Emanuel Peter
epeter at openjdk.org
Thu Jan 30 13:46:52 UTC 2025
On Thu, 30 Jan 2025 13:40:32 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> That would be sad, because we can still profit from all the value verification for other platforms.
>>
>> And who knows, we may add similar instructions for other platforms as well, and then the value verification would come in really handy.
>
> I again re-iterate **a foundational optimization like GVN is target indipendent and our intent here is to check commoning**, hence verifying it for a target which supports all the IR nodes covered by test should suffice for now. Kindly proceed with your testing and share the results.
Things might look target independent now, but we are not just writing tests for the state of now, but for the future too. And that is why increased coverage would be good, as I said above ;)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22863#discussion_r1935635412
More information about the hotspot-compiler-dev
mailing list