RFR: 8339889: Several compiler tests ignore vm flags and not marked as flagless

Tobias Hartmann thartmann at openjdk.org
Fri Jan 31 09:25:47 UTC 2025


On Wed, 22 Jan 2025 01:10:44 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> Tests
> compiler/c2/TestReduceAllocationAndHeapDump.java
> compiler/calls/NativeCalls.java
> compiler/debug/TestStress.java
> compiler/inlining/TestDuplicatedLateInliningOutput.java
> ignore vm flags using limited process builder and not marked as flagless.
> 
> Please note that test
> compiler/inlining/TestDuplicatedLateInliningOutput.java
> is failing with some VM flags. See
> https://bugs.openjdk.org/browse/JDK-8348214
> 
> I haven't excluded test, since it fail with certain non-common flags only.

Changes requested by thartmann (Reviewer).

test/hotspot/jtreg/compiler/inlining/TestDuplicatedLateInliningOutput.java line 62:

> 60: 
> 61:     private static void test(Class<?> launcher, String pattern1, String pattern2) throws Exception {
> 62:         ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder(

I would leave this test as is and mark as flagless.

-------------

PR Review: https://git.openjdk.org/jdk/pull/23224#pullrequestreview-2586085306
PR Review Comment: https://git.openjdk.org/jdk/pull/23224#discussion_r1936927497


More information about the hotspot-compiler-dev mailing list