RFR: 8360116: Add support for AVX10 floating point minmax instruction [v5]

Sandhya Viswanathan sviswanathan at openjdk.org
Wed Jul 2 00:31:41 UTC 2025


On Tue, 1 Jul 2025 23:49:30 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update src/hotspot/cpu/x86/x86_64.ad
>>    
>>    Co-authored-by: Manuel Hässig <manuel at haessig.org>
>>  - Update src/hotspot/cpu/x86/x86_64.ad
>>    
>>    Co-authored-by: Manuel Hässig <manuel at haessig.org>
>
> src/hotspot/cpu/x86/assembler_x86.cpp line 8800:
> 
>> 8798:   attributes.set_is_evex_instruction();
>> 8799:   attributes.set_embedded_opmask_register_specifier(mask);
>> 8800:   attributes.set_address_attributes(/* tuple_type */ EVEX_FVM, /* input_size_in_bits */ EVEX_NObit);
> 
> It looks to me that the tuple_type should be EVEX_FV for all of evminmax ps, pd, ph.

Other than that the rest of the PR looks good to me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25914#discussion_r2178762877


More information about the hotspot-compiler-dev mailing list