RFR: 8360116: Add support for AVX10 floating point minmax instruction [v5]

Jatin Bhateja jbhateja at openjdk.org
Wed Jul 2 02:04:41 UTC 2025


On Wed, 2 Jul 2025 00:29:02 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> src/hotspot/cpu/x86/assembler_x86.cpp line 8800:
>> 
>>> 8798:   attributes.set_is_evex_instruction();
>>> 8799:   attributes.set_embedded_opmask_register_specifier(mask);
>>> 8800:   attributes.set_address_attributes(/* tuple_type */ EVEX_FVM, /* input_size_in_bits */ EVEX_NObit);
>> 
>> It looks to me that the tuple_type should be EVEX_FV for all of evminmax ps, pd, ph.
>
> Other than that the rest of the PR looks good to me.

> It looks to me that the tuple_type should be EVEX_FV for all of evminmax ps, pd, ph.

Yes, all these new vector instructions do have embedded broadcast variants. We don't use them currently,  in the absence of embedded broadcasting, the scalar factor (N) selection for compressed disp8 displacement is the same for both EVEX_FV and EVEX_FVM tuple types.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25914#discussion_r2178831749


More information about the hotspot-compiler-dev mailing list