RFR: 8358568: C2 compilation hits "must have a monitor" assert with -XX:-GenerateSynchronizationCode [v4]

[hanguanqiang]

On Thu, 3 Jul 2025 04:40:33 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> hanguanqiang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Delete .gitpod.yml
>
> The patch seems reasonable from a backporting perspective. Though it does beg the question as to why `do_monitor_enter` does not need the same fix. I suspect this is a very old flag and the code has bit-rotted somewhat. A question for the compiler folk: does `GenerateSynchronizationCode` still have any use or should it be scrapped?
> 
> Thanks

@dholmes-ora @dean-long @shipilev @vnkozlov 
Thanks for the previous reviews! I’ve updated the patch according to the suggestions.
When you have a moment, could you please take another look?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26108#issuecomment-3034151673