RFR: 8360936: Test compiler/onSpinWait/TestOnSpinWaitAArch64.java fails after JDK-8359435 [v4]
Andrew Haley
aph at openjdk.org
Tue Jul 8 08:31:46 UTC 2025
On Mon, 7 Jul 2025 18:19:54 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:
>> Test compiler/onSpinWait/TestOnSpinWaitAArch64.java needs debug info to identify a position of spin wait instructions in generated code. The test switched to use `XX:CompileCommand=print` instead of `XX:+PrintAssembly` to have assembly only for a tested Java method. In release builds `XX:+PrintAssembly` prints out debug info but `XX:CompileCommand=print` does not.
>>
>> This PR reimplements the test to parse instructions and to check them. The test does not rely on debug info anymore.
>>
>> Tested on Linux and MacOS with and without hsdis:
>> - Fastdebug: test passed
>> - Slowdebug: test passed.
>> - Release: test passed.
>
> Evgeny Astigeevich has updated the pull request incrementally with one additional commit since the last revision:
>
> Implement using block_comment
src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 6806:
> 6804:
> 6805: void MacroAssembler::spin_wait() {
> 6806: block_comment("spin_wait");
You need something unique. e.g.
Suggestion:
block_comment("spin_wait_ohthoo8H");
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26072#discussion_r2191835912
More information about the hotspot-compiler-dev
mailing list