RFR: 8360936: Test compiler/onSpinWait/TestOnSpinWaitAArch64.java fails after JDK-8359435 [v4]

Aleksey Shipilev shade at openjdk.org
Tue Jul 8 08:42:48 UTC 2025


On Tue, 8 Jul 2025 08:28:33 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Evgeny Astigeevich has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implement using block_comment
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 6806:
> 
>> 6804: 
>> 6805: void MacroAssembler::spin_wait() {
>> 6806:   block_comment("spin_wait");
> 
> You need something unique. e.g. 
> Suggestion:
> 
>   block_comment("spin_wait_ohthoo8H");

Erm, I don't see why?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26072#discussion_r2191861699


More information about the hotspot-compiler-dev mailing list