RFR: 8361492: [IR Framework] Has too restrictive regex for load and store [v2]

[Christian Hagedorn]

On Mon, 14 Jul 2025 06:16:32 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:

>> Improving store and load regexes + adding test. It's mostly an improve version of a fix I had to do in Valhalla where it was blocking (part of JDK-8361250, blocking JDK-8357785).
>> 
>> The new regex takes into account that classes can implement interfaces, nested classes, and various labels after the `@`. It should be more robust.
>> 
>> Thanks,
>> Marc
>
> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Mostly add spaces
>   
>   and rename, a bit

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestPhaseIRMatching.java line 575:

> 573:     }
> 574: 
> 575:     SingleNest.DoubleNest double_nest = new SingleNest.DoubleNest();

Last nit: We should use camelCase for Java code:
Suggestion:

    SingleNest.DoubleNest doubleNest = new SingleNest.DoubleNest();

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestPhaseIRMatching.java line 763:

> 761:     // @ir_framework/tests/LoadStore$SingleNest$DoubleNest+12 *
> 762:     public int loadDoubleNested() {
> 763:         return double_nest.i;

Suggestion:

        return doubleNest.i;

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestPhaseIRMatching.java line 786:

> 784:     // @ir_framework/tests/LoadStore$SingleNest$DoubleNest+12 *
> 785:     public void storeDoubleNested() {
> 786:         double_nest.i = 1;

Suggestion:

        doubleNest.i = 1;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26269#discussion_r2204498393
PR Review Comment: https://git.openjdk.org/jdk/pull/26269#discussion_r2204498723
PR Review Comment: https://git.openjdk.org/jdk/pull/26269#discussion_r2204498990