RFR: 8361836: RISC-V: Relax min vector length to 32-bit for short vectors [v2]
Fei Yang
fyang at openjdk.org
Tue Jul 15 03:19:40 UTC 2025
On Tue, 15 Jul 2025 01:27:59 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:
>> src/hotspot/cpu/riscv/riscv.ad line 1999:
>>
>>> 1997: } else if (bt == T_SHORT) {
>>> 1998: // To support vector type conversions between short and wider types.
>>> 1999: size = 2;
>>
>> Should we add some `assert` or `guarantee` for uncovered types?
>
> Thanks for the review!
> I think assert or guarantee are unnecessary for types not explicitly covered, as their behavior is safely constrained by general rules and global constraints (e.g., limit the min vector size to 8-byte and minimum size of 2).
I think it's more clear to make this a switch-case listing the other cases as the default like the aarch64 counterpart.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26239#discussion_r2206193272
More information about the hotspot-compiler-dev
mailing list