RFR: 8359965: Enable paired pushp and popp instruction usage for APX enabled CPUs [v5]
Srinivas Vamsi Parasa
sparasa at openjdk.org
Thu Jul 17 18:41:55 UTC 2025
On Thu, 17 Jul 2025 17:26:56 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> change to push_ppx/pop_ppx
>
> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 806:
>
>> 804: }
>> 805:
>> 806: void MacroAssembler::pop_ppx(Register dst) {
>
> Hi @vamsi-parasa , If you rename pop_ppx to pop and push_ppx to push, it will cut down the changes in this patch significantly.
Hi Jatin (@jatin-bhateja), the intent is to make the use of the `pushp/popp` instructions explicit to the user, as not all `push` or `pop` instructions require the PPX feature.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25889#discussion_r2214035483
More information about the hotspot-compiler-dev
mailing list