RFR: 8362515: RISC-V: cleanup NativeFarCall [v5]

Hamlin Li mli at openjdk.org
Fri Jul 25 19:39:55 UTC 2025


On Fri, 25 Jul 2025 15:33:56 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   comments
>
> src/hotspot/cpu/riscv/nativeInst_riscv.hpp line 118:
> 
>> 116:  // private: when common code is using byte_size()
>> 117:  private:
>> 118:   enum {
> 
> I see the enum of NativeFarCall was named as `RISCV_specific_constants`, do we need this for NativeCall?

Thank you having a look.

Seems not, there is no name for this enum in orignal code . And in this file some enums have names, some not, but seems either way is fine, although I think the names are all redundant here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26370#discussion_r2231880820


More information about the hotspot-compiler-dev mailing list