RFR: 8362515: RISC-V: cleanup NativeFarCall [v5]
Feilong Jiang
fjiang at openjdk.org
Sat Jul 26 00:25:54 UTC 2025
On Fri, 25 Jul 2025 08:39:39 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> Hi,
>> Can you help to review this patch?
>>
>> By https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/macroAssembler_riscv.hpp#L1270, there are far call, indirect call, reloc call.
>> <del>NativeFarCall is in fact a reloc call, the name is confusing, better to rename it to RelocCall.</del>
>> Finally, choose to remove the NativeFarCall and delegation from NativeCall to NativeFarCall, and move all the implementation to NativeCall itself.
>> Also add some comments and do some other simple cleanup.
>>
>> Thanks!
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>
> comments
Marked as reviewed by fjiang (Committer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/26370#pullrequestreview-3057183153
More information about the hotspot-compiler-dev
mailing list