RFR: 8344942: Template-Based Testing Framework [v71]
Emanuel Peter
epeter at openjdk.org
Mon Jun 2 14:08:12 UTC 2025
On Mon, 2 Jun 2025 12:27:21 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 91 commits:
>>
>> - Merge branch 'master' into JDK-8344942-TemplateFramework-v3
>> - validation tests
>> - dollar and hashtag parsing validatiaon
>> - wip refactor parsing dollar and hashtag
>> - more fixes from Christian
>> - more improvements
>> - more suggestions applied
>> - good practice
>> - rename template arguments
>> - more from Christian
>> - ... and 81 more: https://git.openjdk.org/jdk/compare/90d6ad01...cb7037e7
>
> test/hotspot/jtreg/compiler/lib/template_framework/TemplateBinding.java line 43:
>
>> 41: * Creates a new {@link TemplateBinding} that has no Template bound to it yet.
>> 42: */
>> 43: public TemplateBinding() {}
>
> Can also be removed since it's the default constructor that is automatically added for you.
> Suggestion:
If I do that, then `javadoc` complains:
test/hotspot/jtreg/compiler/lib/template_framework/TemplateBinding.java:37: warning: use of default constructor, which does not provide a comment
public class TemplateBinding<T extends Template> {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2121254922
More information about the hotspot-compiler-dev
mailing list