RFR: 8344942: Template-Based Testing Framework [v71]

[Emanuel Peter]

On Mon, 2 Jun 2025 13:45:07 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 91 commits:
>> 
>>  - Merge branch 'master' into JDK-8344942-TemplateFramework-v3
>>  - validation tests
>>  - dollar and hashtag parsing validatiaon
>>  - wip refactor parsing dollar and hashtag
>>  - more fixes from Christian
>>  - more improvements
>>  - more suggestions applied
>>  - good practice
>>  - rename template arguments
>>  - more from Christian
>>  - ... and 81 more: https://git.openjdk.org/jdk/compare/90d6ad01...cb7037e7
>
> test/hotspot/jtreg/compiler/lib/template_framework/Renderer.java line 266:
> 
>> 264:             case StringToken(String s) -> {
>> 265:                 renderStringWithDollarAndHashtagReplacements(s);
>> 266:             }
> 
> Suggestion:
> 
>             case StringToken(String s) -> renderStringWithDollarAndHashtagReplacements(s);

I think I prefer the uniformity of the brackets as I have it. Would that be ok for you too?

> test/hotspot/jtreg/compiler/lib/template_framework/Renderer.java line 324:
> 
>> 322:             case AddNameToken(Name name) -> {
>> 323:                 currentCodeFrame.addName(name);
>> 324:             }
> 
> Suggestion:
> 
>             case AddNameToken(Name name) -> currentCodeFrame.addName(name);

Like above: I like the uniformity of the brackets here. Is that ok for you to keep as is?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2121288248
PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2121290027