RFR: 8344942: Template-Based Testing Framework [v71]

[Emanuel Peter]

On Mon, 2 Jun 2025 12:21:42 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 91 commits:
>> 
>>  - Merge branch 'master' into JDK-8344942-TemplateFramework-v3
>>  - validation tests
>>  - dollar and hashtag parsing validatiaon
>>  - wip refactor parsing dollar and hashtag
>>  - more fixes from Christian
>>  - more improvements
>>  - more suggestions applied
>>  - good practice
>>  - rename template arguments
>>  - more from Christian
>>  - ... and 81 more: https://git.openjdk.org/jdk/compare/90d6ad01...cb7037e7
>
> test/hotspot/jtreg/compiler/lib/template_framework/Token.java line 74:
> 
>> 72:             case Float s   -> outputList.add(new StringToken(Renderer.format(s)));
>> 73:             case Boolean s -> outputList.add(new StringToken(Renderer.format(s)));
>> 74:             case List l    -> parseList(l, outputList);
> 
> Not sure if we should use a raw `List` here. Would `List<?>` work as well? Would then need to update `parseList(List<Object> inputList ...)` to `List<?>` as well.

What exactly do you think is the problem here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2121300491