RFR: 8358534: Bailout in Conv2B::Ideal when type of cmp input is not supported

[Aleksey Shipilev]

On Wed, 4 Jun 2025 06:55:25 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> src/hotspot/share/opto/convertnode.cpp line 86:
>> 
>>> 84:         return nullptr;
>>> 85:       }
>>> 86: 
>> 
>> @JohnTortugo Would it not have been better to put this check inside the `else` branch?
>
> I agree, the `return nullptr;` should have been added below the assert in the else branch, no check required.

Yes, putting `return nullptr;` into existing branch would have been cleaner. One more reason to wait for reviews! We can do a quick follow-up that sweeps this return to its better place, if you feel strongly about it. Note this would likely get backported, so being extra-clean pays off the process hassle. It is about 15 minute deal for me, I am happy to do it as a penance for not coming up with it myself :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25627#discussion_r2126256450