RFR: 8358534: Bailout in Conv2B::Ideal when type of cmp input is not supported

[Cesar Soares Lucas]

On Wed, 4 Jun 2025 10:25:30 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> I agree, the `return nullptr;` should have been added below the assert in the else branch, no check required.
>
> Yes, putting `return nullptr;` into existing branch would have been cleaner. One more reason to wait for reviews! We can do a quick follow-up that sweeps this return to its better place, if you feel strongly about it. Note this would likely get backported, so being extra-clean pays off the process hassle. It is about 15 minute deal for me, I am happy to do it as a penance for not coming up with it myself :)

I agree that just adding the return after the assert would have been a better option. I opted for adding the `if (cmp == nullptr)` because of excess of caution.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25627#discussion_r2127115196