RFR: 8357982: Fix several failing BMI tests with -XX:+UseAPX [v8]
Sandhya Viswanathan
sviswanathan at openjdk.org
Fri Jun 6 16:57:52 UTC 2025
On Fri, 6 Jun 2025 07:46:32 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> A) Patch extends the following tests with hard-coded encoding checks for various BMI instructions to cover REX2 or extended EVEX encodings supported by APX.
>>
>>
>> compiler/intrinsics/bmi/verifycode/AndnTestI.java
>> compiler/intrinsics/bmi/verifycode/AndnTestL.java
>> compiler/intrinsics/bmi/verifycode/BzhiTestI2L.java
>> compiler/intrinsics/bmi/verifycode/LZcntTestL.java
>> compiler/intrinsics/bmi/verifycode/TZcntTestL.java
>>
>>
>> B) After integration of JDK-8349582, which added APX NDD support, AndN instruction selection patterns that expect (Xor SRC, -1) as one of its operands were not getting selected because of a lower-cost generic immediate pattern match; patch fixes this issue through strict predicate checks.
>>
>> Above tests are now passing, validations were carried out using Intel Software Development emulator.
>>
>> Kindly review and share your feedback.
>>
>> Best Regards,
>> Jatin
>
> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comments resoltions
Looks good to me.
-------------
Marked as reviewed by sviswanathan (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25501#pullrequestreview-2905507817
More information about the hotspot-compiler-dev
mailing list