RFR: 8358772: Template-Framework Library: Primitive Types [v2]

[Emanuel Peter]

On Thu, 12 Jun 2025 10:46:25 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Apply suggestions from code review
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>    Co-authored-by: Manuel Hässig <manuel at haessig.org>
>>  - Apply suggestions from code review
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>    Co-authored-by: Manuel Hässig <manuel at haessig.org>
>
> test/hotspot/jtreg/compiler/lib/template_framework/Token.java line 29:
> 
>> 27: import java.util.ArrayList;
>> 28: import java.util.List;
>> 29: 
> 
> The imports can now be removed (cannot make a suggestion, it's hidden).

done

> test/hotspot/jtreg/testlibrary_tests/template_framework/examples/TestPrimitiveTypes.java line 50:
> 
>> 48: import static compiler.lib.template_framework.Template.$;
>> 49: import static compiler.lib.template_framework.Template.addDataName;
>> 50: import static compiler.lib.template_framework.Template.dataNames;
> 
> Unused:
> Suggestion:

it is a duplicate actually!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25672#discussion_r2142384146
PR Review Comment: https://git.openjdk.org/jdk/pull/25672#discussion_r2142392171