RFR: 8358772: Template-Framework Library: Primitive Types [v3]

[Emanuel Peter]

On Thu, 12 Jun 2025 10:47:56 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review suggestions applied
>
> test/hotspot/jtreg/compiler/lib/template_framework/library/CodeGenerationDataNameType.java line 45:
> 
>> 43:      * @return A random constant value.
>> 44:      */
>> 45:     public Object con();
> 
> You can remove all the public identifies since the methods are implicitly public.

good point, done :)

> test/hotspot/jtreg/compiler/lib/template_framework/library/CodeGenerationDataNameType.java line 106:
> 
>> 104:      * List of all {@link PrimitiveType}s.
>> 105:      */
>> 106:     public static final List<PrimitiveType> PRIMITIVE_TYPES = List.of(
> 
> Same with the constants: They are implicitly public static final.

done!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25672#discussion_r2142406305
PR Review Comment: https://git.openjdk.org/jdk/pull/25672#discussion_r2142406768